Skip to content

Telemetry: Send index stats on dev exit #32168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 1, 2025

Closes N/A

What I did

Send canceled(dev) with index stats on dev exit

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Here's how I tested:

  1. Run storybook dev with STORYBOOK_TELEMETRY_DEBUG=1
  2. Observe index stats in dev event
  3. Add or remove a story
  4. Exit and observe that a canceled(dev) event gets sent with updated index stats

🦋 Canary release

This pull request has been released as version 0.0.0-pr-32168-sha-afa539f0. Try it out in a new sandbox by running npx [email protected] sandbox or in an existing project with npx [email protected] upgrade.

More information
Published version 0.0.0-pr-32168-sha-afa539f0
Triggered by @shilman
Repository storybookjs/storybook
Branch shilman/add-dev-cancel-event
Commit afa539f0
Datetime Fri Aug 1 09:11:14 UTC 2025 (1754039474)
Workflow run 16671161434

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=32168

Copy link

nx-cloud bot commented Aug 1, 2025

View your CI Pipeline Execution ↗ for commit ebc6ced

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-01 13:13:17 UTC

@shilman shilman added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry ci:normal labels Aug 1, 2025
@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Aug 1, 2025

Package Benchmarks

Commit: ebc6ced, ran on 1 August 2025 at 13:02:25 UTC

The following packages have significant changes to their size or dependencies:

storybook

Before After Difference
Dependency count 51 51 0
Self size 41.36 MB 41.76 MB 🚨 +405 KB 🚨
Dependency size 18.13 MB 18.13 MB 0 B
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 52 52 0
Self size 1 KB 1 KB 0 B
Dependency size 59.49 MB 59.90 MB 🚨 +405 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 220 220 0
Self size 585 KB 585 KB 0 B
Dependency size 103.95 MB 104.36 MB 🚨 +405 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 189 189 0
Self size 31 KB 31 KB 0 B
Dependency size 88.04 MB 88.45 MB 🚨 +405 KB 🚨
Bundle Size Analyzer Link Link

@shilman shilman marked this pull request as ready for review August 1, 2025 02:11
@shilman shilman self-assigned this Aug 1, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@shilman shilman requested a review from tmeasday August 1, 2025 03:56
@shilman shilman force-pushed the shilman/add-dev-cancel-event branch from 6d84768 to afa539f Compare August 1, 2025 03:57
@shilman shilman force-pushed the shilman/add-dev-cancel-event branch from afa539f to ebc6ced Compare August 1, 2025 12:49
@shilman shilman merged commit c5d386f into next Aug 1, 2025
54 checks passed
@shilman shilman deleted the shilman/add-dev-cancel-event branch August 1, 2025 13:17
yannbf pushed a commit that referenced this pull request Aug 4, 2025
Telemetry: Send index stats on dev exit
(cherry picked from commit c5d386f)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants