Skip to content

CLI: Do not fail incompatible package check in doctor if only core packages used #31886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

mrginglymus
Copy link
Contributor

@mrginglymus mrginglymus commented Jun 27, 2025

Closes #31891

What I did

storybook doctor was throwing a spurious error 'No Storybook dependencies found in the package.json' if run on a package that only had core storybook packages.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Fixed a bug in storybook doctor command where it incorrectly reported 'No Storybook dependencies found' error when only core packages were present in package.json.

  • Modified package compatibility checking logic in code/lib/cli-storybook/src/doctor/getIncompatibleStorybookPackages.ts to handle core packages correctly
  • Added unit tests in getIncompatibleStorybookPackages.test.ts to verify core package handling
  • Removed unnecessary dependency on 'versions' import, simplifying to use only 'storybookCorePackages'
  • Streamlined dependency filtering to properly include all Storybook packages in the check

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Jun 27, 2025

View your CI Pipeline Execution ↗ for commit 8b3265c.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-27 08:45:45 UTC

@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 30, 2025
@valentinpalkovic valentinpalkovic merged commit 33923f9 into storybookjs:next Jun 30, 2025
59 of 67 checks passed
valentinpalkovic added a commit that referenced this pull request Jul 1, 2025
CLI: Do not fail incompatible package check in doctor if only core packages used
(cherry picked from commit 33923f9)
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
11 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ## Failed to run doctor checks, no dependencies found in package.json
3 participants