Skip to content

Core: Various fixes #31870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 30, 2025
Merged

Core: Various fixes #31870

merged 6 commits into from
Jun 30, 2025

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 25, 2025

What I did

Added some missing ARIA labels and prevented accessing a property of undefined.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Accessibility and defensive programming improvements in core UI components, focusing on ARIA labels and null handling.

  • Added aria-label to Modal close button in code/core/src/components/components/Modal/Modal.styled.tsx for better screen reader support
  • Added aria-label to 'Create new story' button in code/core/src/manager/components/sidebar/Sidebar.tsx improving sidebar accessibility
  • Fixed potential undefined error in getDescendantIds function by adding null coalescing for entry.children in code/core/src/manager/utils/tree.ts

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Jun 25, 2025

View your CI Pipeline Execution ↗ for commit 0ab7802.

Command Status Duration Result
nx run-many -t check -c production --parallel=7 ✅ Succeeded 1m 9s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 4m 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-30 13:56:09 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Jun 25, 2025

Package Benchmarks

Commit: 0ab7802, ran on 30 June 2025 at 14:00:23 UTC

The following packages have significant changes to their size or dependencies:

storybook

Before After Difference
Dependency count 51 51 0
Self size 31.72 MB 31.73 MB 🚨 +16 KB 🚨
Dependency size 17.43 MB 17.43 MB 0 B
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 52 52 0
Self size 1 KB 1 KB 0 B
Dependency size 49.15 MB 49.16 MB 🚨 +16 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 217 217 0
Self size 582 KB 582 KB 0 B
Dependency size 94.75 MB 94.77 MB 🚨 +16 KB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 186 186 0
Self size 31 KB 31 KB 0 B
Dependency size 78.85 MB 78.86 MB 🚨 +16 KB 🚨
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 25, 2025
@ghengeveld ghengeveld self-assigned this Jun 25, 2025
@ghengeveld ghengeveld moved this to In Progress in Core Team Projects Jun 25, 2025
@ghengeveld ghengeveld merged commit 70fa4cd into next Jun 30, 2025
58 of 62 checks passed
@ghengeveld ghengeveld deleted the various-fixes branch June 30, 2025 20:02
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Jun 30, 2025
ghengeveld added a commit that referenced this pull request Jul 8, 2025
Core: Various fixes
(cherry picked from commit 70fa4cd)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants