CLI: Fix package manager instantiation in empty directories

[yannbf]

Closes #

What I did

The logic was faulty because a package.json would not exist at the time we instantiate a JSPackage manager. Now it does, plus I extracted the logic to figure out a package manager type without the need to instantiate a package manager.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Improves package manager initialization in empty directories by refactoring the detection and instantiation logic for better robustness and maintainability.

• Simplified directory empty check by consolidating ignored files into a single FILES_TO_IGNORE array in code/lib/create-storybook/src/scaffold-new-project.ts
• Added getPackageManagerType() method in JsPackageManagerFactory for better type detection and caching control
• Modified package manager initialization in code/lib/create-storybook/src/initiate.ts to detect type before instantiation
• Fixed Yarn 1 handling in empty directories by switching to npm earlier in the process
• Improved code organization by extracting package manager detection logic into dedicated methods

[greptile-apps]

LGTM

_{3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit e03db7e.

Command	Status	Duration	Result
nx run-many -t build --parallel=3	✅ Succeeded	1m 27s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-06-11 09:07:57 UTC