-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Addon Docs: Fix SyntaxHighlighter "Copy" button by avoiding potentially mocked clipboard #31682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
View your CI Pipeline Execution ↗ for commit fd1e207.
☁️ Nx Cloud last updated this comment at |
This PR partially addresses the issue by delegating write operations to window.top.navigator.clipboard, but full functionality still requires proper allow="clipboard-write" permissions on the SB's iframe container. This is required for the use cases where you would have implemented your own copy to clipboard util that would still rely on SB's iframe instance. |
…-action Addon Docs: Fix SyntaxHighlighter "Copy" button by avoiding potentially mocked clipboard (cherry picked from commit 5ee8cf4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Closes #31626
What I did
Use clipboard from top frame to avoid potentially mocked clipboard in the preview.
This won't fix the problem when viewing a story standalone (without a manager), but that is unavoidable.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Fixes the SyntaxHighlighter component's "Copy" button by accessing clipboard API from the top-level window instead of the potentially mocked iframe context.
code/core/src/components/components/syntaxhighlighter/syntaxhighlighter.tsx
to use top frame's clipboard API