Fix to README add-ons section #3079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unmentioned addons Alphabetize addons
hexpunk
commented
Feb 25, 2018
| @@ -3,7 +3,7 @@ | |||
| [](https://circleci.com/gh/storybooks/storybook) | |||
| [](https://www.codefactor.io/repository/github/storybooks/storybook) | |||
| [](https://snyk.io/test/github/storybooks/storybook/8f36abfd6697e58cd76df3526b52e4b9dc894847) | |||
| [](https://bettercodehub.com/results/storybooks/storybook) [](https://codecov.io/gh/storybooks/storybook) | |||
There was a problem hiding this comment.
This was just my editor removing trailing whitespace.
Codecov Report
@@ Coverage Diff @@
## master #3079 +/- ##
=======================================
Coverage 36.08% 36.08%
=======================================
Files 438 438
Lines 9447 9447
Branches 882 905 +23
=======================================
Hits 3409 3409
+ Misses 5472 5457 -15
- Partials 566 581 +15
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
There was a dead link in the main README file to a non-existent comments add-on.
What I did
I removed the dead link. While I was in there, I added links and short blurbs for the add-ons that weren't listed. I also alphabetized the list of add-ons.
How to test
N/A
Is this testable with jest or storyshots?
No
Does this need a new example in the kitchen sink apps?
No
Does this need an update to the documentation?
This is an update to documentation.
If your answer is yes to any of these, please make sure to include it in your PR.