Skip to content

Conversation

ndelangen
Copy link
Member

Issue: Netlify example was missing for angular example

What I did

  • Added a netlify site
  • Added a if case for the pre-defined environment variable to deploy the right example

@ndelangen ndelangen self-assigned this Dec 22, 2017
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Dec 22, 2017
@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #2533 into release/3.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #2533   +/-   ##
============================================
  Coverage        20.18%   20.18%           
============================================
  Files              398      398           
  Lines             8838     8838           
  Branches           937      938    +1     
============================================
  Hits              1784     1784           
- Misses            6339     6345    +6     
+ Partials           715      709    -6
Impacted Files Coverage Δ
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/jest/src/hoc/provideJestResult.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/index.js 0% <0%> (ø) ⬆️
addons/info/src/components/types/Shape.js 5.88% <0%> (ø) ⬆️
...i/src/modules/ui/components/stories_panel/index.js 18.51% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 29.28% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 11.11% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e87234...7c09e95. Read the comment docs.

@ndelangen ndelangen changed the base branch from release/3.3 to master December 22, 2017 14:41
@ndelangen ndelangen force-pushed the netlify-for-angularexample branch from 5f83737 to 7c09e95 Compare December 22, 2017 14:49
@ndelangen
Copy link
Member Author

@ndelangen ndelangen changed the base branch from master to release/3.3 December 22, 2017 14:55
@alterx
Copy link
Member

alterx commented Dec 22, 2017

It's ALIVE! :D

@ndelangen ndelangen merged commit b41f04a into release/3.3 Dec 22, 2017
@ndelangen ndelangen deleted the netlify-for-angularexample branch December 22, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants