Skip to content

Conversation

ndelangen
Copy link
Member

Issue: Netlify example was missing for newly added official storybook example

What I did

  • Added a netlify site
  • Added a if case for the pre-defined environment variable to deploy the right example

@ndelangen ndelangen self-assigned this Dec 22, 2017
@ndelangen ndelangen requested a review from tmeasday December 22, 2017 12:33
@ndelangen ndelangen changed the base branch from master to release/3.3 December 22, 2017 12:33
@codecov
Copy link

codecov bot commented Dec 22, 2017

Codecov Report

Merging #2532 into release/3.3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release/3.3    #2532   +/-   ##
============================================
  Coverage        20.18%   20.18%           
============================================
  Files              398      398           
  Lines             8838     8838           
  Branches           947      945    -2     
============================================
  Hits              1784     1784           
+ Misses            6312     6310    -2     
- Partials           742      744    +2
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
...modules/ui/components/stories_panel/text_filter.js 30.98% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.42% <0%> (ø) ⬆️
.../src/modules/ui/components/stories_panel/header.js 29.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8.21% <0%> (ø) ⬆️
...ddons/actions/src/containers/ActionLogger/index.js 2.98% <0%> (ø) ⬆️
addons/actions/src/lib/decycle.js 36.61% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/addon_panel/index.js 34.78% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
...ddons/actions/src/lib/types/function/isReserved.js 14.28% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc82759...84ffcd1. Read the comment docs.

@ndelangen
Copy link
Member Author

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Dec 22, 2017
@Hypnosphi Hypnosphi merged commit 6e87234 into release/3.3 Dec 22, 2017
@Hypnosphi Hypnosphi deleted the netlify-for-officialexample branch December 22, 2017 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants