-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
UI: Hide keyboard shortcuts entry from menu when shortcuts are disabled #23411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Hide keyboard shortcuts entry from menu when shortcuts are disabled #23411
Conversation
Thanks a lot for this PR! Let's hold this off until the discussions in #23351 are sorted. |
@yannbf I think the discussions are resolved. I think this PR could use another look. |
View your CI Pipeline Execution ↗ for commit 2ced0e9.
☁️ Nx Cloud last updated this comment at |
67ef945
to
28fb35a
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
Before | After | Difference | |
---|---|---|---|
Dependency count | 56 | 49 | 🎉 -7 🎉 |
Self size | 41.37 MB | 31.87 MB | 🎉 -9.50 MB 🎉 |
Dependency size | 18.22 MB | 17.44 MB | 🎉 -785 KB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/ember
Before | After | Difference | |
---|---|---|---|
Dependency count | 203 | 205 | 🚨 +2 🚨 |
Self size | 28 KB | 28 KB | 🎉 -5 B 🎉 |
Dependency size | 28.05 MB | 28.86 MB | 🚨 +810 KB 🚨 |
Bundle Size Analyzer | Link | Link |
@storybook/react-native-web-vite
Before | After | Difference | |
---|---|---|---|
Dependency count | 163 | 161 | 🎉 -2 🎉 |
Self size | 32 KB | 35 KB | 🚨 +3 KB 🚨 |
Dependency size | 23.66 MB | 23.60 MB | 🎉 -62 KB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/vue3-vite
Before | After | Difference | |
---|---|---|---|
Dependency count | 105 | 104 | 🎉 -1 🎉 |
Self size | 34 KB | 34 KB | 🎉 -14 B 🎉 |
Dependency size | 42.79 MB | 42.74 MB | 🎉 -51 KB 🎉 |
Bundle Size Analyzer | Link | Link |
sb
Before | After | Difference | |
---|---|---|---|
Dependency count | 57 | 50 | 🎉 -7 🎉 |
Self size | 1 KB | 1 KB | 🎉 -2 B 🎉 |
Dependency size | 59.59 MB | 49.31 MB | 🎉 -10.28 MB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/cli
Before | After | Difference | |
---|---|---|---|
Dependency count | 221 | 215 | 🎉 -6 🎉 |
Self size | 585 KB | 582 KB | 🎉 -3 KB 🎉 |
Dependency size | 103.99 MB | 93.75 MB | 🎉 -10.24 MB 🎉 |
Bundle Size Analyzer | Link | Link |
@storybook/codemod
Before | After | Difference | |
---|---|---|---|
Dependency count | 190 | 184 | 🎉 -6 🎉 |
Self size | 31 KB | 31 KB | 🎉 -2 B 🎉 |
Dependency size | 88.08 MB | 77.89 MB | 🎉 -10.20 MB 🎉 |
Bundle Size Analyzer | Link | Link |
create-storybook
Before | After | Difference | |
---|---|---|---|
Dependency count | 1 | 1 | 0 |
Self size | 12.51 MB | 12.47 MB | 🎉 -41 KB 🎉 |
Dependency size | 98 KB | 98 KB | 🎉 -2 B 🎉 |
Bundle Size Analyzer | Link | Link |
…abled UI: Hide keyboard shortcuts entry from menu when shortcuts are disabled (cherry picked from commit a3274ac)
Related issue #23351
What I did
Currently, if keyboard shortcuts are disabled via the manager config
the shortcut page can still be accessed via the menu:
The changes in this PR will hide the shortcuts entry when shortcuts are disabled:

Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]