-
Notifications
You must be signed in to change notification settings - Fork 137
Add new LegacyDialog entity #385
Conversation
|
@Hammie sorry, but clang is more strict. If you create |
|
@q4a Thank you very much! Nothing quite like waking up to see problems already solved 👍 |
espkk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good!
I see you removed some utf8-related code from the original Dialog though. Did you mean to drop its support or it's still supported somehow?
PS
@q4a, iirc from our discussion clang is not more strict, it just doesn't support this C++20 feature yet 😅
@espkk I assume you are talking about the modified |
|
@espkk I've tried creating a unit test to make sure it still works with non-ascii characters, but the presence of the renderer makes that almost impossible. The theory as to why it should still work is that neither ' ' or '\n' could ever by confused for other characters in utf-8 - as is the case for all ascii characters <= code point 127 - because multi-byte code points always have the highest bit active. Also did a quick test with some Cyrillic text, no idea what it says but it looks like it is rendering correctly: |
Sounds good! Thanks But this needs a rebase now 😢 |
espkk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only 1 minor note - please move new header ito src if it's not public
include is for public headers which are getting exported
# Conflicts: # src/libs/dialog/src/dialog.cpp # src/libs/renderer/include/dx9render.h

Adds a LegacyDialog entity that implements the old Seadogs 2 dialog system for use in New Horizons.
Does not yet include pagination or mood settings for the head animation.
Also includes #383