Skip to content

Conversation

@mprahl
Copy link
Contributor

@mprahl mprahl commented May 21, 2024

This will save on memory usage in the cache.

This will save on memory usage in the cache.

Signed-off-by: mprahl <[email protected]>
@sonarqubecloud
Copy link

Copy link
Contributor

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Looks good to me, definitely helpful as-is. I only wonder if we want to make this even more configurable, or if anyone would want these fields... But since we're the only ones using it so far, those might be unnecessary feature requests

@openshift-ci
Copy link

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl
Copy link
Contributor Author

mprahl commented May 21, 2024

/unhold after discussion

@mprahl mprahl merged commit 23a92f7 into stolostron:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants