Use the new actor provider interface #500
Conversation
mbabker
force-pushed
the
actor-provider
branch
2 times, most recently
from
0a42b16 to
df53613
Compare
mbabker
force-pushed
the
actor-provider
branch
from
df53613 to
1415e20
Compare
|
Thanks @mbabker |
|
@stof, just wondering if there's any ETA on the next release? Thanks so far :) |
|
I still have 1 change I want to do to be compatible with the new way of doing things (regarding the way the locale is handled). My plan is to do it this weekend (hopefully) and then do a release. |
| <call method="setActorProvider"> | ||
| <argument type="service" id="stof_doctrine_extensions.tool.actor_provider" /> | ||
| </call> |
There was a problem hiding this comment.
I have the feeling that adding this, in conjunction with the LoggableListener::getUsername implementation, creates a BC break: even if one calls LoggableListener::setUsername manually, the fact that the actor is always injected will make the actor takes precedence over the value injected by the user in every scenario.
There was a problem hiding this comment.
One of our projects was affected by it. It took a while to debug, but fortunately, the change was made quickly by creating a new ActorProvider and set the User there.
Follows doctrine-extensions/DoctrineExtensions#2914 and the 3.19 release
Replaces #499
Fixes #498
Probably implicitly fixes some other issues as well