🐛 Fix Zbb shift instructions
#1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iterative shift logic of the CLMUL instructions was permanently blocking other B shift instructions.
ecstrema
approved these changes
Mar 14, 2025
|
I wonder why it was set to '0' at first then... |
|
Thanks for reviewing!
Just a typo I guess 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shift operations of the
Zbbinstructions caused a permanent ALU stall (and thus, a timeout leading to an illegal instruction exception) whenCPU_FAST_SHIFT_ENandRISCV_ISA_Zbkcare both disabled.Bug discovered by @ecstrema in #640 (comment).