Skip to content

Conversation

@johnjaylward
Copy link
Contributor

@johnjaylward johnjaylward commented Nov 6, 2017

What problem does this code solve?
fix for issue #379

Risks
None.

Changes to the API?
None.

Will this require a new release?
Yes.

Should the documentation be updated?
No.

Does it break the unit tests?
Yes, but new unit tests were added that pass with this change. See stleary/JSON-Java-unit-test#81

Was any code refactored in this commit?
No.

Review status
ACCEPTED. Starting 3 day window for comments.

@stleary
Copy link
Owner

stleary commented Nov 7, 2017

Starting 3 day window for comments.
Actually, the code change does not appear to break the unit tests, unless I am missing something.
Deferring new release, since we are in a 3 month self-imposed moratorium pending feedback/reaction to the Android support changes in #350.
Thanks @enoes for catching the problem and @johnjaylward for fixing it.

@stleary stleary merged commit 28e09dc into stleary:master Nov 11, 2017
@wiiitek
Copy link

wiiitek commented Feb 4, 2018

👍

@johnjaylward johnjaylward deleted the FixFalsePositiveSimilar branch February 4, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants