Decimal places for PriceAmount fixed at 2 digits - need 4 digits e.g. for fuel invoice

[harzmann]

PriceAmount is formatted or rounded to 2 decimal places. However, for example, for fuel bills, 4 decimal places are required for the price per liter. Temporary Save function modified:
Writer.WriteValue(_formatDecimal(tradeLineItem.GrossUnitPrice.Value,4));

[stephanstapel]

Thanks for your suggestion. I'd be more than happy if you could create a PR. I propose to format the decimal with two digits in case the actual value has two or less digits and use four digits only in case they are really set in the decimal value.

This will do it:

Math.Round(tradeLineItem.GrossUnitPrice.Value, 3) != tradeLineItem.GrossUnitPrice.Value

Please add a test case to https://github.com/stephanstapel/ZUGFeRD-csharp/blob/master/ZUGFeRD-Test/XRechnungUBLTests.cs

[HolgerPfeifer]

And the same would be useful for the AllowanceCharge.Amount.

[stephanstapel]

@HolgerPfeifer : would you like to contribute?

[HolgerPfeifer]

Yes, I would like. It will take me some time to get my devolopment environment ready for GitHub. Currently I only use local BitBucket repositories.

[ernie1000]

Same problem here. With Version 12.8.0 of the DLL the following lines are written:

    <ram:GrossPriceProductTradePrice>
      <ram:ChargeAmount>24.8600</ram:ChargeAmount>
      <ram:BasisQuantity unitCode="C62">1.0000</ram:BasisQuantity>
    </ram:GrossPriceProductTradePrice>
    <ram:NetPriceProductTradePrice>
      <ram:ChargeAmount>22.3700</ram:ChargeAmount>
      <ram:BasisQuantity unitCode="C62">1.0000</ram:BasisQuantity>
    </ram:NetPriceProductTradePrice>

Both price fields are defined with 4 decimals.

With Version 15.0.0 both fields are filled with 2 decimals even when they come with 4 decimals. I need 4 decimals when a rabate has to be calculated.
Please return to the behavior of 12.8.0

[stephanstapel]

Hi @ernie1000 ,

This change was made intentionally and cannot be 'just reversed' as this component is part of lots of applications.
I am happy if you send in a pull request to add digits on demand as I suggested above,

[ernie1000]

In other profiles than XRechnung the decimals for "GrossPriceProductTradePrice" and "NetPriceProductTradePrice" are still written with 4 places.
With a quick and dirty hack, a change of the resulting xml file, the validators are not complaining about 4 decimal places.
I appreciate this DLL and all the work, which was done, very much, but I thought, this software is made to build e-invoices easy and comfortable and not for changing the values inside.
Since I'm not on the latest Visual Studio 2022, I'm not able to send a pull request now but my suggestion is something like:
TradeLineItem.AmountDecimals=4;
with a default of '2'.
Once more, this software is great and saves a lot of time when working with e-invoices.

[DaveHalma]

Be careful when changing “formatDecimal” in “InvoiceDescriptorWriter” thus this can lead to many errors when validating.

[stephanstapel]

We should rely on the standard:
https://github.com/stephanstapel/ZUGFeRD-csharp/blob/master/documentation/zugferd23en/Documentation/1.%20FACTUR-X%201.0.07%20EN.pdf

i.e.

It would be great if you could check the writers if it matches these decimal rules for all versions and formats.

[DaveHalma]

The writers work great for me, but I needed to adjust “Unit Price Amount” and “Quantity” manually to 4 due to some rounding issues. I think it should be left to anyone to adjust the size of the numbers behind the decimal separator, as this seems quite individual. On the other hand, we could implement the maximum of allowed decimals just for accessibility. Your call.

[wh1980]

The validators are not complaining when using values with 4 decimals in GrossPriceProductTradePrice\ChargeAmount, GrossPriceProductTradePrice\AppliedTradeAllowanceCharge\ActualAmount and also in NetPriceProductTradePrice\ChargeAmount. We need it like that as our users can switch between 2 and 4 decimals for the unit price amounts:

<ram:SpecifiedLineTradeAgreement> <ram:GrossPriceProductTradePrice> <ram:ChargeAmount>9.9925</ram:ChargeAmount> <ram:BasisQuantity unitCode="MMT">1.0000</ram:BasisQuantity> <ram:AppliedTradeAllowanceCharge> <ram:ChargeIndicator> <udt:Indicator>false</udt:Indicator> </ram:ChargeIndicator> <ram:ActualAmount>2.7502</ram:ActualAmount> </ram:AppliedTradeAllowanceCharge> </ram:GrossPriceProductTradePrice> <ram:NetPriceProductTradePrice> <ram:ChargeAmount>7.2423</ram:ChargeAmount> <ram:BasisQuantity unitCode="MMT">1.0000</ram:BasisQuantity> </ram:NetPriceProductTradePrice> </ram:SpecifiedLineTradeAgreement>

We need something like this:
TradeLineItem.UnitPriceAmountDecimals=4;