Correctly map astro-float features to astro-float-num features
#34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the crates features and dependencies to correctly map a feature in the top-level crate to features inside astro-float-num. Additionally, support for setting `default-features=false` is added.
|
Thank you for the fix. |
|
Closing, since did not hear back from the author, and the suggested changes have been implemented as part of other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the features in this crate to correctly map to features in the
astro-float-numcrate.The existing features for the
astro-floatcrate don't actually enable/disable anything in theastro-float-numcrate becauseastro-float-numis used as a dependency with default features. Thus, if a user defines a dependency onastro-floatwithdefault-features = false,astro-float-numwill still build with theserde,random, andstdfeatures.By defaulting the
astro-float-numdependency todefault-features = false, the use case mentioned above works as expected.