Add default stack policy to prevent replace and delete on KMS and RDS #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A stack policy exists in the assets and is currently added to all stacks. The policy does not allow replace or delete actions on RDS or KMS resources. I plan to pass the policy in as a string to upsert stack as a way to set the policy later through extensions or cli flags.
Switching to packr removed the need to have lint workarounds
- Define constants for policies - Update references to use GetAsset - Update tests Tests still failing. Looks like tests are just bad and need to be updated.
- Fixed issue where template processing was still required - Added tests to template methods - Add template processing on templates where needed
cplee
suggested changes
Sep 25, 2018
provider/aws/cloudformation.go
Outdated
| return err | ||
| } | ||
| templateBody := aws.String(templateBodyBytes.String()) | ||
| templateBody, err := templates.GetAsset(templateName, templates.AddData(templateData), |
There was a problem hiding this comment.
i like what you have going here, but i think it'd be even cleaner to use a fluent api so that you get:
.AddData(templateData)
.DecorateTemplate(cfnMgr.extensionsManager, stackName)
thoughts?
There was a problem hiding this comment.
Yeah I'd considered it. As a heavy user of nodejs though I've ran into so many issues with fluent api's in native Promise chaining that turn code into huge try/catch blocks with poor error propagation and 100 line stack traces. It also means I need a struct to reference so I can return it from each of these funcs. In general I think it just adds unnecessary complexity.
mneil
added a commit
to mneil/mu
that referenced
this pull request
Sep 25, 2018
cplee
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.