Added bluetooth dongle support for Rpi4 users #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 25, 2025 16:02
This reverts commit b43ec97.
stefanor
reviewed
Feb 5, 2025
|
Thank you for looking at this! |
Thanks to you for creating it! I battled for quite some time before discovering some comments about the RPi4 bluetooth. So I tried a dongle and it just worked. |
|
Yeah, I'll admit that I use an external Bluetooth dongle too... But I just disable the internal one. |
stefanor
requested changes
May 12, 2025
| updates: [{ | ||
| values: [{ | ||
| path: "plugins.victronBLE.status", | ||
| value: "active" |
There was a problem hiding this comment.
What purpose does this serve? I don't see this path documented anywhere
| ) | ||
|
|
||
| T = TypeVar('T', bound=DeviceData) | ||
| import inspect |
There was a problem hiding this comment.
Please sort stdlib imports together
| VEBusData, | ||
| ) | ||
|
|
||
| T = TypeVar('T', bound=DeviceData) |
| super().__init__() | ||
| except TypeError as e: | ||
| logger.debug(f"Parent __init__ args required: {e}") | ||
| raise |
There was a problem hiding this comment.
This all seems pretty unnecessary.
| logger.debug( | ||
| f"Received data from {bl_device.address.lower()}: {raw_data.hex()}" | ||
| f"Received {len(raw_data)}B packet from {bl_device.address.lower()} " | ||
| f"(RSSI: {rssi}) @ {datetime.datetime.now().isoformat()}: " |
There was a problem hiding this comment.
Log entries are already timestamped, why include the time again here?
| values.append({ | ||
| "path": f"electrical.devices.{id_}.deviceName", | ||
| "value": bl_device.name | ||
| }) |
| ) -> SignalKDeltaValues: | ||
| values: SignalKDeltaValues = [ | ||
| { | ||
| "path": f"electrical.deviceMetadata.{id_}.name", |
|
|
||
| # Add device name to all deltas | ||
| values.append({ | ||
| "path": f"electrical.devices.{id_}.deviceName", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Victron BLE Plugin: Raspberry Pi 4 Stability & Multi-Adapter Support
Summary
This update adds critical support for external Bluetooth adapters to address instability with Raspberry Pi 4's built-in Bluetooth hardware when used with Victron devices. Users can now select between adapters (e.g.,
hci1for USB dongles) via SignalK UI to bypass Pi 4's unreliable native Bluetooth stack.Key Changes
🛠️ Pi 4 Hardware Workarounds
🪲 Why This Matters for Pi 4 Users
Pi 4's built-in Bluetooth:
➔ Fails to maintain stable GATT connections
➔ Causes packet loss with Victron devices
External dongles (e.g., CSR4.0/Plugable BT4LE) resolve these issues.
Full Changelog
Features
007d6c8: Core Bluetooth adapter selection logic9471a9d: UI configuration for adapter switchingee255ed: Packet logging (size/timestamp/RSSI) for debuggingFixes & Stability
d9ba0c3: Compatibility with Bleak 0.20+ APIs3e7aa1c: Adapter selection via OS environment6a21b55: Health monitoring and restart logicCode Quality
c62a146/a911e39: Type hint improvements4dcba99: Reduced log noise for productionVerification Steps
hci1→ Confirm logs show[DEBUG] Using Bluetooth adapter hci1electrical.devices.*.deviceNameTested Hardware: Raspberry Pi 4 (Buster) + Victron Orion XS/SmartShunt + Plugable USB-BT4LE dongle.
Requires:
bleak>=0.20.0