Skip to content

Conversation

@anoofmhd
Copy link

@anoofmhd anoofmhd commented Nov 11, 2025

Resolves #5592.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a new incremental moving mean and variance accumulator: @stdlib/stats/incr/nanmmeanvar.

  • This module behaves similarly to @stdlib/stats/incr/mmeanvar, but skips NaN values instead of propagating them.

  • Includes implementation, tests, documentation, TypeScript definitions, REPL help file, benchmarks, and examples.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No additional information.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I used ChatGPT to assist in understanding spec expectations and drafting documentation wording.
The implementation and test logic were written and verified manually.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Nov 11, 2025
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Nov 11, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 11, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmmeanvar $\color{green}138/138$
$color{green}+100.00%$
$\color{green}11/11$
$color{green}+100.00%$
$\color{green}2/2$
$color{green}+100.00%$
$\color{green}138/138$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte self-requested a review November 11, 2025 17:33
@kgryte
Copy link
Member

kgryte commented Nov 11, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 11, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 11, 2025

// EXPORTS //

module.exports = incrnanmmeanvar; No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
module.exports = incrnanmmeanvar;
module.exports = incrnanmmeanvar;

This file is missing a trailing newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmmeanvar

4 participants