Fixed issue with absent gas fee #18704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkjr
requested review from
micieslak,
caybro,
alexjba and
noeliaSD
as code owners
vkjr
commented
Aug 22, 2025
| @@ -71,8 +71,8 @@ Rectangle { | |||
| GasSelector { | |||
| id: gasSelector | |||
| width: parent.width | |||
| getGasNativeCryptoValue: function(gasPrice, gasAmount) { | |||
| return Utils.getGasDecimalValue(root.selectedAsset.chainId, gasPrice, gasAmount) | |||
| getGasNativeCryptoValue: function(gasPrice, gasAmount, chainId) { | |||
There was a problem hiding this comment.
While searching for a bug I also noticed that root.selectedAsset.chainId is undefined most of the time, so replaced it with argument modelData.fromNetwork passed from GasSelector
There was a problem hiding this comment.
Hmm yeah Bridge is still multi-chain so I guess the token model used for the selector doesn't have a single chain associated with them. Perhaps if we do SimpleBridge like we did SimpleSend we can revert this.
Jenkins BuildsClick to see older builds (8)
|
dlipicar
approved these changes
Aug 22, 2025
ui/imports/utils/Utils.qml
Outdated
| @@ -855,7 +855,7 @@ QtObject { | |||
|
|
|||
| function getGasDecimalValue(chainID, gasValue, gasLimit) { | |||
There was a problem hiding this comment.
ugh this function's name is not very clear. Even the arguments have confusing name, they should be something like "gasPrice" and "gasAmount"
ui/imports/utils/Utils.qml
Outdated
| @@ -855,7 +855,7 @@ QtObject { | |||
|
|
|||
| function getGasDecimalValue(chainID, gasValue, gasLimit) { | |||
| let rawValue = nativeTokenGasToRaw(chainID, gasValue) | |||
| rawValue = StatusQUtils.AmountsArithmetic.times(rawValue, StatusQUtils.AmountsArithmetic.fromNumber(1, gasLimit)) | |||
| rawValue = StatusQUtils.AmountsArithmetic.times(rawValue, StatusQUtils.AmountsArithmetic.fromNumber(gasLimit)) | |||
| @@ -71,8 +71,8 @@ Rectangle { | |||
| GasSelector { | |||
| id: gasSelector | |||
| width: parent.width | |||
| getGasNativeCryptoValue: function(gasPrice, gasAmount) { | |||
| return Utils.getGasDecimalValue(root.selectedAsset.chainId, gasPrice, gasAmount) | |||
| getGasNativeCryptoValue: function(gasPrice, gasAmount, chainId) { | |||
There was a problem hiding this comment.
Hmm yeah Bridge is still multi-chain so I guess the token model used for the selector doesn't have a single chain associated with them. Perhaps if we do SimpleBridge like we did SimpleSend we can revert this.
alaibe
approved these changes
Aug 25, 2025
saledjenic
approved these changes
Aug 25, 2025
ui/imports/utils/Utils.qml
Outdated
| let rawValue = nativeTokenGasToRaw(chainID, gasValue) | ||
| rawValue = StatusQUtils.AmountsArithmetic.times(rawValue, StatusQUtils.AmountsArithmetic.fromNumber(1, gasLimit)) | ||
| return nativeTokenRawToDecimal(chainID, rawValue) | ||
| function calculateGasCost(chainID, gasPriceInGwei, gasAmount) { |
There was a problem hiding this comment.
This function is general, and I wouldn't put Gwei in a variable name. Maybe better to name it gasPriceInGasUnit or just gasPrice and add a comment.
vkjr
added a commit
that referenced
this pull request
Aug 25, 2025
* Fixed issue with absent gas fee * function reanamed to improve readability * argument renamed accordingly to pr review
alaibe
pushed a commit
that referenced
this pull request
Aug 27, 2025
* Fixed issue with absent gas fee * function reanamed to improve readability * argument renamed accordingly to pr review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #18649
Before the fix estimated "Ethereum transaction fee" for bridge was displayed as "0.00 USD" (while total fee was calculated correctly).
That happened because of incorrect usage of
AmountsArithmetic.fromNumber()function that gotgasLimitas a second argument which actually used as multiplier. As a result - overflow happened.Affected areas
Bridge
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
How to test