Fix/swap modal freezing after approval #18694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (43)
|
Khushboo-dev-cpp
force-pushed
the
fix/SwapModalFreezingAfterApproval
branch
7 times, most recently
from
acaa7d0 to
a6cc271
Compare
Khushboo-dev-cpp
requested review from
friofry,
vkjr and
glitchminer
and removed request for
a team
Khushboo-dev-cpp
force-pushed
the
fix/SwapModalFreezingAfterApproval
branch
from
a6cc271 to
ae92084
Compare
|
@Khushboo-dev-cpp this PR fixes the problem. I was able to approve a swap and it didn't freeze. It moved to the next step once it received the signal that the TX was done. Good job |
saledjenic
approved these changes
Aug 26, 2025
alaibe
approved these changes
Aug 26, 2025
vkjr
approved these changes
Aug 26, 2025
Khushboo-dev-cpp
force-pushed
the
fix/SwapModalFreezingAfterApproval
branch
from
ae92084 to
b67f1f6
Compare
noticed only on linux fixes #18627
Khushboo-dev-cpp
force-pushed
the
fix/SwapModalFreezingAfterApproval
branch
from
b67f1f6 to
4f45dbd
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18627
status-go PR: status-im/status-go#6868
What does the PR do
Affected areas
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Screen.Recording.2025-08-25.at.17.11.04.mov
Impact on end user
How to test
Risk