Actor select #5299
Actor select #5299
Conversation
🦋 Changeset detectedLatest commit: 5ba73cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/core/src/types.ts
Outdated
| @@ -1911,6 +1911,12 @@ export interface Subscription { | |||
| unsubscribe(): void; | |||
| } | |||
|
|
|||
| export type Selection<TSelected> = Readable<TSelected>; | |||
There was a problem hiding this comment.
this is unused, do we need this alias? it probably could be dropped
| @@ -1990,6 +1996,10 @@ export interface ActorRef< | |||
| emitted: TEmitted & (TType extends '*' ? unknown : { type: TType }) | |||
| ) => void | |||
| ) => Subscription; | |||
| select<TSelected, TSnapshot>( | |||
There was a problem hiding this comment.
TSnapshot is already available in the scope here (it's an existing type parameter of ActorRef), so u dont need it here - only TSelected is needed
There was a problem hiding this comment.
I get compilation error when I remove TSnapshot and then run pnpm typecheck, see GitHub Actions. Not sure on how to resolve it. Reverting to use TSnapshot for now.
I looked into adding a generic for TSnapshot on Actor, see below. But that ended up in a lot of changes not really in the scope of this PR. @Andarist any suggestions?
export class Actor<TLogic extends AnyActorLogic, TSnapshot extends SnapshotFrom<TLogic>>
implements
ActorRef<SnapshotFrom<TLogic>, EventFromLogic<TLogic>, EmittedFrom<TLogic>>
{
....
}There was a problem hiding this comment.
@Andarist Any idea how to resolve this without a major refactor? Is it required in order to merge the PR?
|
@Andarist @davidkpiano |
The select function in @xstate/store is very useful. This PR adds a similar select function to the actor. This is to make the transition from @xstate/store to an xstate machine easier. I've used the same naming of types as in @xstate/store to make it consistent.
I used the tests in @xstate/store as inspiration to what to test.
I hope you find the PR useful! Thanks for an awesome library!