Submit all scene URLs to Stashbox #5894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Unfortunately this will no longer automatically treat unmatched URLs as studio URLs:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
My comment was in reference to someone using older than v0.22.0 Stash (which lacks URLs support) and trying to submit a draft. I'm not even sure if that's relevant to this change though. I just saw |
Contributor
Author
Yes this does not affect that. |
Merged
smith113-p
added a commit
to smith113-p/stash
that referenced
this pull request
Jun 8, 2025
The code looks like it does because it initially used string pointers; however, the version that landed used a regular string array, so we can just the = operator.
smith113-p
added a commit
to smith113-p/stash-box
that referenced
this pull request
Jun 8, 2025
Now that Stash supports sending more than one URL at a time (stashapp/stash#5894), this code treats unmatched URLs as a studio URL even if multiple URLs were submitted. This allows, for example, submitting a Clips4Sale URL and a studio URL and having both matched.
WithoutPants
pushed a commit
that referenced
this pull request
Jun 11, 2025
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Oct 22, 2025
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Oct 22, 2025
The code looks like it does because it initially used string pointers; however, the version that landed used a regular string array, so we can just the = operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #1868
Closes #5899
Closes #3951