Skip to content

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Jan 16, 2024

Description

asciicast

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09edf32) 82.86% compared to head (73b8a47) 92.11%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3129      +/-   ##
============================================
+ Coverage     82.86%   92.11%   +9.24%     
============================================
  Files           575      139     -436     
  Lines         32125    16250   -15875     
  Branches       1873        0    -1873     
============================================
- Hits          26620    14968   -11652     
+ Misses         4676     1282    -3394     
+ Partials        829        0     -829     
Flag Coverage Δ
console ?
controller ?
standalone 92.11% <100.00%> (+<0.01%) ⬆️
unittests 92.11% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit ea8c736 into star-whale:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants