Skip to content

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Jan 16, 2024

Description

image

#3104

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added enhancement ❤️ New feature or request client 🌈 labels Jan 16, 2024
@tianweidut tianweidut self-assigned this Jan 16, 2024
@tianweidut tianweidut force-pushed the enhance/list-standalone branch from f166da5 to c1b4e03 Compare January 16, 2024 04:18
@tianweidut tianweidut linked an issue Jan 16, 2024 that may be closed by this pull request
@tianweidut tianweidut changed the title enhance(client): make the list(model/runtime/dataset) output of standalone instance consitent with cloud/server style. enhance(client): make the list(model/runtime/dataset) output of standalone instance consitent with cloud/server style Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c474ca6) 82.87% compared to head (fee4314) 92.08%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3126      +/-   ##
============================================
+ Coverage     82.87%   92.08%   +9.21%     
============================================
  Files           575      139     -436     
  Lines         32125    16262   -15863     
  Branches       1873        0    -1873     
============================================
- Hits          26623    14975   -11648     
+ Misses         4674     1287    -3387     
+ Partials        828        0     -828     
Flag Coverage Δ
console ?
controller ?
standalone 92.08% <100.00%> (-0.04%) ⬇️
unittests 92.08% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut force-pushed the enhance/list-standalone branch from c1b4e03 to fee4314 Compare January 16, 2024 06:40
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 68e7c4c into star-whale:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tune client list command
2 participants