Skip to content

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Nov 29, 2023

Description

  • Add TextToImage type
  • Change Message.role(str) to bot(bool)
  • Support getting arg spec from the func signature

Content of the web-handler's job.yaml:

serving:
- concurrency: 1
  expose: 8080
  extra_kwargs:
    search_modules:
    - main
  func_name: StandaloneModel._serve_handler
  module_name: starwhale.core.model.model
  name: serving
  replicas: 1
  service_spec:
    apis:
    - components:
      - component_spec_value_type: STRING
        name: user_input
      - component_spec_value_type: LIST
        name: history
      - componentValueSpecFloat:
          defaultVal: 0.5
        component_spec_value_type: FLOAT
        name: temperature
      - componentValueSpecFloat:
          defaultVal: 0.9
        component_spec_value_type: FLOAT
        name: top_p
      - componentValueSpecInt:
          defaultVal: 100
        component_spec_value_type: INT
        name: max_new_tokens
      inference_type: llm_chat
      uri: fake_chat_bot
    version: 0.0.2
  show_name: virtual handler for model serving
  virtual: true

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (24d2acc) 82.94% compared to head (2abc86a) 91.81%.
Report is 3 commits behind head on main.

Files Patch % Lines
client/starwhale/api/_impl/service/types/types.py 64.51% 11 Missing ⚠️
...t/starwhale/api/_impl/service/types/text_to_img.py 86.66% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3044      +/-   ##
============================================
+ Coverage     82.94%   91.81%   +8.86%     
============================================
  Files           567      135     -432     
  Lines         31434    15898   -15536     
  Branches       1839        0    -1839     
============================================
- Hits          26074    14596   -11478     
+ Misses         4549     1302    -3247     
+ Partials        811        0     -811     
Flag Coverage Δ
console ?
controller ?
standalone 91.81% <79.45%> (-0.08%) ⬇️
unittests 91.81% <79.45%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit e7ef6a6 into star-whale:main Nov 29, 2023
@jialeicui jialeicui deleted the text2img branch November 29, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants