Skip to content

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added enhancement ❤️ New feature or request client 🌈 labels Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3395e9d) 82.75% compared to head (894787f) 82.84%.

Files Patch % Lines
client/starwhale/api/_impl/service/types/types.py 75.00% 5 Missing ⚠️
client/starwhale/api/_impl/service/types/llm.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3037      +/-   ##
============================================
+ Coverage     82.75%   82.84%   +0.09%     
- Complexity     3159     3160       +1     
============================================
  Files           560      557       -3     
  Lines         30650    30470     -180     
  Branches       1839     1778      -61     
============================================
- Hits          25364    25244     -120     
+ Misses         4474     4417      -57     
+ Partials        812      809       -3     
Flag Coverage Δ
console ?
controller 73.95% <ø> (+0.02%) ⬆️
standalone 91.91% <95.00%> (-0.01%) ⬇️
unittests 91.91% <95.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 24d2acc into star-whale:main Nov 29, 2023
@jialeicui jialeicui deleted the component-spec branch November 29, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants