Skip to content

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Nov 27, 2023

Description

asciicast

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c57144a) 82.77% compared to head (a6dd437) 91.89%.
Report is 9 commits behind head on main.

Files Patch % Lines
client/starwhale/mngt/__init__.py 0.00% 3 Missing ⚠️
client/starwhale/utils/config.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3035      +/-   ##
============================================
+ Coverage     82.77%   91.89%   +9.12%     
============================================
  Files           558      134     -424     
  Lines         30635    15799   -14836     
  Branches       1838        0    -1838     
============================================
- Hits          25358    14519   -10839     
+ Misses         4465     1280    -3185     
+ Partials        812        0     -812     
Flag Coverage Δ
console ?
controller ?
standalone 91.89% <93.65%> (-0.07%) ⬇️
unittests 91.89% <93.65%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut force-pushed the feat/local-server-command branch from 2cbff54 to eff9a4e Compare November 28, 2023 06:45
@tianweidut tianweidut requested a review from anda-ren November 28, 2023 06:48
@tianweidut tianweidut marked this pull request as ready for review November 28, 2023 06:48
@tianweidut tianweidut force-pushed the feat/local-server-command branch 3 times, most recently from 4571e88 to 0731a57 Compare November 28, 2023 06:54
@tianweidut tianweidut force-pushed the feat/local-server-command branch from 77c1c17 to a6dd437 Compare November 28, 2023 10:34
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 0607171 into star-whale:main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants