Skip to content

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jul 20, 2023

Description

thanks @jckhang for catching this bug.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added bug 🐛 Something isn't working controller 🏘️ labels Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2537 (0f11e64) into main (8b2b9d1) will decrease coverage by 8.14%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2537      +/-   ##
============================================
- Coverage     82.75%   74.62%   -8.14%     
- Complexity     2647     2648       +1     
============================================
  Files           451      348     -103     
  Lines         24524    12577   -11947     
  Branches       1481     1467      -14     
============================================
- Hits          20296     9386   -10910     
+ Misses         3572     2536    -1036     
+ Partials        656      655       -1     
Flag Coverage Δ
console ?
controller 74.62% <100.00%> (+<0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i/starwhale/mlops/schedule/k8s/K8sJobTemplate.java 81.36% <100.00%> (+0.62%) ⬆️

... and 103 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit ad16845 into star-whale:main Jul 20, 2023
@jialeicui jialeicui deleted the fix-annotation branch July 20, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants