Skip to content

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Jul 6, 2023

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui July 6, 2023 07:50
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #2472 (fd66113) into main (67f8fec) will decrease coverage by 11.30%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #2472       +/-   ##
===========================================
- Coverage   91.05%   79.76%   -11.30%     
===========================================
  Files         101        1      -100     
  Lines       11773       84    -11689     
  Branches       14       14               
===========================================
- Hits        10720       67    -10653     
+ Misses       1053       17     -1036     
Flag Coverage Δ
console 79.76% <ø> (ø)
standalone ?
unittests 79.76% <ø> (-11.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 100 files with indirect coverage changes

@waynelwz waynelwz changed the title update(console): job failreason support tooltip/copy, new copy & text component update(console): support job failed reason, add new copy & text component Jul 6, 2023
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 21d3261 into star-whale:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants