Skip to content

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Jul 2, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #2439 (6d0ed0e) into main (19d4484) will increase coverage by 0.02%.
The diff coverage is 86.30%.

@@             Coverage Diff              @@
##               main    #2439      +/-   ##
============================================
+ Coverage     76.02%   76.05%   +0.02%     
- Complexity     2574     2589      +15     
============================================
  Files           335      335              
  Lines         12115    12064      -51     
  Branches       1405     1395      -10     
============================================
- Hits           9211     9175      -36     
+ Misses         2267     2253      -14     
+ Partials        637      636       -1     
Flag Coverage Δ
console ?
controller 76.05% <86.30%> (+0.04%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...starwhale/mlops/domain/blob/CachedBlobService.java 81.81% <81.81%> (ø)
...i/starwhale/mlops/domain/blob/BlobServiceImpl.java 90.00% <90.00%> (ø)

... and 1 file with indirect coverage changes

@xuchuan xuchuan requested a review from jialeicui July 2, 2023 18:57
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 536d8fd into star-whale:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants