Skip to content

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Jun 29, 2023

Description

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added the e2e label Jun 29, 2023
@tianweidut tianweidut requested a review from goldenxinxing June 29, 2023 07:59
@tianweidut tianweidut marked this pull request as draft June 29, 2023 08:03
@tianweidut tianweidut added bug 🐛 Something isn't working ci 🕹️ labels Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2429 (5a3f8f6) into main (2eec8d6) will decrease coverage by 3.64%.
The diff coverage is n/a.

❗ Current head 5a3f8f6 differs from pull request most recent head f480e82. Consider uploading reports for the commit f480e82 to get more accurate results

@@             Coverage Diff              @@
##               main    #2429      +/-   ##
============================================
- Coverage     83.39%   79.76%   -3.64%     
============================================
  Files           434        1     -433     
  Lines         23682       84   -23598     
  Branches       1405       14    -1391     
============================================
- Hits          19749       67   -19682     
+ Misses         3299       17    -3282     
+ Partials        634        0     -634     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 433 files with indirect coverage changes

@tianweidut tianweidut marked this pull request as ready for review June 29, 2023 09:51
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 8e63d3d into star-whale:main Jun 29, 2023
@tianweidut tianweidut deleted the fix/e2e-release branch September 5, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working ci 🕹️ e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants