Skip to content

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jun 25, 2023

Description

  • ProxyServlet support proxying task web handler and vscode in dev mode
  • Add feature switch job-proxy
  • JobConverter and TaskConverter render the final URL with the job-proxy setting
dev.mode.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui force-pushed the dev-proxy branch 2 times, most recently from e5c86d7 to 8f6081e Compare June 25, 2023 10:40
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #2399 (e714d8c) into main (ea65f8c) will decrease coverage by 7.93%.
The diff coverage is 38.41%.

@@             Coverage Diff              @@
##               main    #2399      +/-   ##
============================================
- Coverage     83.69%   75.77%   -7.93%     
- Complexity     2525     2543      +18     
============================================
  Files           432      334      -98     
  Lines         23385    11947   -11438     
  Branches       1361     1382      +21     
============================================
- Hits          19573     9053   -10520     
+ Misses         3186     2266     -920     
- Partials        626      628       +2     
Flag Coverage Δ
console ?
controller 75.77% <38.41%> (-0.58%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/ai/starwhale/mlops/common/ProxyServlet.java 27.64% <18.54%> (-39.02%) ⬇️
...n/security/ProjectNameExtractorDataStoreMixed.java 74.57% <40.00%> (-3.21%) ⬇️
.../starwhale/mlops/common/proxy/WebServerInTask.java 85.00% <85.00%> (ø)
.../ai/starwhale/mlops/common/proxy/ModelServing.java 85.71% <85.71%> (ø)
...ain/java/ai/starwhale/mlops/domain/job/DevWay.java 100.00% <100.00%> (+40.00%) ⬆️
...tarwhale/mlops/domain/job/ModelServingService.java 73.01% <100.00%> (+0.10%) ⬆️
...whale/mlops/domain/job/converter/JobConverter.java 63.00% <100.00%> (+0.50%) ⬆️
...ale/mlops/domain/task/converter/TaskConverter.java 84.84% <100.00%> (+1.51%) ⬆️

... and 112 files with indirect coverage changes

@goldenxinxing goldenxinxing self-requested a review June 26, 2023 10:00
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing self-requested a review June 26, 2023 10:01
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit c5d489e into star-whale:main Jun 26, 2023
@jialeicui jialeicui deleted the dev-proxy branch June 26, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants