Skip to content

Conversation

tianweidut
Copy link
Member

Description

asciicast

Modules

  • Client
  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #2387 (b5ee9fd) into main (e5c921c) will increase coverage by 16.57%.
The diff coverage is 84.61%.

@@              Coverage Diff              @@
##               main    #2387       +/-   ##
=============================================
+ Coverage     74.51%   91.08%   +16.57%     
=============================================
  Files           330       98      -232     
  Lines         11759    11187      -572     
  Branches       1338        0     -1338     
=============================================
+ Hits           8762    10190     +1428     
+ Misses         2385      997     -1388     
+ Partials        612        0      -612     
Flag Coverage Δ
controller ?
standalone 91.08% <84.61%> (?)
unittests 91.08% <84.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/model.py 93.93% <50.00%> (ø)
client/starwhale/api/_impl/dataset/model.py 98.83% <100.00%> (ø)
client/starwhale/core/dataset/view.py 64.59% <100.00%> (ø)

... and 425 files with indirect coverage changes

@tianweidut tianweidut force-pushed the enhance/dataset-build-patch branch from 15e411b to b5ee9fd Compare June 21, 2023 11:31
@tianweidut tianweidut marked this pull request as ready for review June 21, 2023 11:31
@tianweidut tianweidut requested a review from anda-ren June 21, 2023 11:31
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit 5fe6ced into star-whale:main Jun 25, 2023
@tianweidut tianweidut deleted the enhance/dataset-build-patch branch September 5, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants