Parameter for loading transformer & tokenizer with local_files_only #1408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jemoka
approved these changes
Aug 5, 2024
Member
Jemoka
left a comment
Jemoka
left a comment
There was a problem hiding this comment.
lgtm: are there any foundation cache codepaths which is using foundation cache but not this which could cause versioning problems? otherwise this looks great
Jemoka
reviewed
Aug 5, 2024
| self.download_method = normalize_download_method(download_method) | ||
| if (self.download_method is DownloadMethod.DOWNLOAD_RESOURCES or | ||
| (self.download_method is DownloadMethod.REUSE_RESOURCES and not os.path.exists(os.path.join(self.dir, "resources.json")))): |
Member
There was a problem hiding this comment.
re slack though: I do think we should we should merge these two options into one
Collaborator
Author
some of the training methods might, i suppose, in that they'd clobber any previous transformer & model because there's no option to not go to HF |
AngledLuffa
force-pushed
the
local_files_only
branch
from
f21f4d7 to
9418d1b
Compare
Add local_files_only as a parameter to the FoundationCache, in case that winds up being useful NONE download_method doesn't download anything, including HF, rather than adding a new mode
Member
|
got it; this new scheme looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter for loading transformer & tokenizer with local_files_only
Add local_files_only as a parameter to the FoundationCache, in case that winds up being useful