-
Notifications
You must be signed in to change notification settings - Fork 2
Version and style sync across standard-
repos
#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@searls Do we have an appetite to look at the latest Sorbet rules and decide which ones we want to incorporate? |
@mjankowski Updating the bundler version is what's causing the 2.7 check to fail. We might want to pull that out of this PR, and think about dropping Ruby 2.7 support in a separate PR. |
@maxveldink happy to defer to you. I haven't used sorbet since we made this gem so feel free to drive things here |
Will take a stab in the coming days 👍🏻 |
9bba29a
to
5ed919b
Compare
Ah, I missed that we had not yet dropped 2.7 in this repo. Updated the PR to remove the bundler version lockfile bump, will watch CI on next run. I assume (based on linked PR discusssion) that we might WANT to drop 2.7? If so, I can do that as followup here. |
I think this needs workflow approval to run. |
Crikey, another CI failure, from This time around I rolled all changes back and rebuilt it while actually running 2.7 locally. Maybe that works. |
Context: standardrb/standard#658
As described in linked PR, bump some stuff to get a clean, no warnings local run, add simplecov, etc. This one also includes an actions/checkout bump which removes CI warnings.
No issues found w/ standard 1.41.1 bump here.
As noted in linked PR, this one (sorbet) was the only one with remaining warning/deprecation output, which is like:
These are coming from (and have since been fixed in)
rubocop-sorbet
. We're on 0.7.0, 0.8.7 is current, they were fixed in 0.8.4.Presumably whenever this is next version bumped and rules contemplated, that warning will go away.