Skip to content

Conversation

@andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Building cmdstan versions < 2.31 fails on M1/M2 macs due to a makefile setting which has since been patched. This PR adds the automatic updating of the stanc makefile where necessary so that M1/M2 users can install older versions of cmdstan.

I've also added the -Wno-deprecated-declarations flag to suppress the warnings coming from Boost

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #756 (a422cee) into master (e396878) will decrease coverage by 1.94%.
The diff coverage is 100.00%.

❗ Current head a422cee differs from pull request most recent head f7c9231. Consider uploading reports for the commit f7c9231 to get more accurate results

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   88.23%   86.30%   -1.94%     
==========================================
  Files          12       12              
  Lines        4107     4117      +10     
==========================================
- Hits         3624     3553      -71     
- Misses        483      564      +81     
Impacted Files Coverage Δ
R/install.R 52.06% <100.00%> (-10.07%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, potentially one thing to fine-tune, but feel free to merge.

@andrjohns andrjohns merged commit ab30e07 into master Apr 6, 2023
@rok-cesnovar rok-cesnovar deleted the m1-stanc branch June 26, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants