Skip to content

Conversation

@rok-cesnovar
Copy link
Member

Summary

Running the following script:

library(cmdstanr)

file <- system.file("logistic.stan", package = "cmdstanr")

model <- cmdstan_model(stan_file=file, compile=FALSE)
model$check_syntax(stanc_options = list("debug-mem-patterns"))

produced the following output:

vector[K] beta: AoSStan program is syntactically correct

which is missing a newline. This PR fixes this issue. This was reported by @avehtari.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2022

Codecov Report

Merging #689 (0cb44c6) into master (dd01ab1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
+ Coverage   89.95%   89.98%   +0.02%     
==========================================
  Files          12       12              
  Lines        3654     3653       -1     
==========================================
  Hits         3287     3287              
+ Misses        367      366       -1     
Impacted Files Coverage Δ
R/model.R 91.42% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rok-cesnovar rok-cesnovar merged commit 03d568b into master Aug 13, 2022
@rok-cesnovar rok-cesnovar deleted the add-newline-to-check-syntax-output branch August 13, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants