Use double-quoting when calling grep.exe on Windows #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
(Unable to run unit tests fully locally - but the fix in this PR is very minor and all within strings)
Summary
Using grep on windows, the filename and match string need to be provided (as I see it) with double-quotes, not single-quotes. Without that, I am seeing grep failures pulling out the metadata. See comments on #660 which is also working in that section of code, where Sys.which() is used to determine where grep.exe is.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Imperial College London
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: