Skip to content

Conversation

@rok-cesnovar
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

In the edge case where the users do not have grep.exe in their system path, we need to wrap the Sys.which() call in the with_path call just like we do the rest of the system calls.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@rok-cesnovar rok-cesnovar linked an issue Jun 13, 2022 that may be closed by this pull request
@rok-cesnovar
Copy link
Member Author

The 4.2 Windows tests are failing for other reasons (see #660) so this should be good to go.

@rok-cesnovar rok-cesnovar merged commit b5bab54 into master Jun 13, 2022
@rok-cesnovar rok-cesnovar deleted the fix-grep-windows branch June 13, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Supplied CSV file is corrupt! - but not reading from csv.

2 participants