add: documentation to help Windows developers to use openssl #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't this issue not unique to openssl but true of any node module that isn't on PATH? |
|
Interestingly, even though I added it to PATH, I would still get the error.
…On Wed, Jul 6, 2022 at 2:07 PM Stalgia Grigg ***@***.***> wrote:
Isn't this issue not unique to openssl but true of any node module that
isn't on PATH?
—
Reply to this email directly, view it on GitHub
<#168 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNSQUZDT5AN7EXNSOA4PYLVSXYSBANCNFSM52YAWELQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
stalgiag
reviewed
Jul 6, 2022
stalgiag
requested changes
Jul 13, 2022
| @@ -18,6 +18,7 @@ function calculate() { | |||
| } | |||
|
|
|||
| function draw() { | |||
| setViewerPosition(0, 0, 20); | |||
There was a problem hiding this comment.
Would be better to move the object rather than viewer to keep these examples conceptually simple
| @@ -26,6 +26,7 @@ function calculate() { | |||
| } | |||
|
|
|||
| function draw() { | |||
| setViewerPosition(0, 0, 20); | |||
There was a problem hiding this comment.
Probably better to separate these changes from the openssl documentation changes. This commit can be reverted and then a new branch can be made with a new PR.
…r during VR" This reverts commit 4c6ed54.
|
reverted that commit, will move the objects in another PR |
stalgiag
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows users should git bash to prevent this openssl error