Skip builder image build when it is unmodified #1284
Conversation
|
Skipping CI for Draft Pull Request. |
|
Molter73
force-pushed
the
mauro/skip-builder
branch
from
22b1969 to
0213d8b
Compare
| COLLECTOR_BUILDER_TAG="${DEFAULT_BUILDER_TAG}" | ||
| if [[ "${{ github.event_name }}" == 'pull_request' ]]; then | ||
| COLLECTOR_BUILDER_TAG="${{ inputs.collector-tag }}" | ||
| fi | ||
|
|
||
| echo "COLLECTOR_BUILDER_TAG=${COLLECTOR_BUILDER_TAG}" >> "$GITHUB_ENV" | ||
| echo "collector-builder-tag=${COLLECTOR_BUILDER_TAG}" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
When the builder does not need to be rebuilt, how is the collector-build-tag going to be provided to the collector build ?
Maybe it is empty and then takes the default from Makefile-constants.mk ?
If this is true, maybe it would make sense to not set its value for the "default" case here.
There was a problem hiding this comment.
I'll test it, but when skipping I think the output turns into an empty string and our makefiles turn an empty COLLECTOR_BUILDER_TAG env variable to the default (cache):
collector/Makefile-constants.mk
Lines 2 to 4 in d6cd0ff
There was a problem hiding this comment.
Actually, in the latest CI run, that is what happened:
https://github.com/stackrox/collector/actions/runs/5856587306/job/15876735578?pr=1284
There was a problem hiding this comment.
I think that skipping setting of the value when we are in the default case would be coherent (have the default value's "value" in one place). But, hey, it works !
Description
Skip the builder image build when no changes would make modifications to the actual image (i.e.: no change to third_party libraries and the builder directory itself).
Checklist
Testing Performed
build-builder-imageshould force build the builder.third_partyorbuilderdirectories should build the builder. (CI run)third_partyorbuilderdirectories should skip building the builder. (CI run)