Skip to content

Build multiarch full collector images #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 4, 2023
Merged

Build multiarch full collector images #1271

merged 6 commits into from
Sep 4, 2023

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Aug 4, 2023 •
edited
Loading

Description

Use the downstream built drivers for P and Z alongside the downstream built images to build full collectors images.

Checklist

  • Investigated and inspected CI test results

Testing Performed

  • Skipping multiarch builds in PRs should build a single x86 full image.

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Molter73 Molter73 marked this pull request as ready for review August 4, 2023 12:43
@Molter73 Molter73 requested a review from a team as a code owner August 4, 2023 12:43
@Molter73 Molter73 marked this pull request as draft August 4, 2023 13:29
@Molter73 Molter73 force-pushed the mauro/full-multiarch-images branch from 2190392 to d512014 Compare August 7, 2023 10:40
@Molter73 Molter73 marked this pull request as ready for review August 8, 2023 07:23
@Molter73 Molter73 force-pushed the mauro/full-multiarch-images branch 2 times, most recently from bf18ffb to 569284d Compare August 14, 2023 13:47
@Molter73 Molter73 force-pushed the mauro/full-multiarch-images branch from 569284d to 8b960c2 Compare August 31, 2023 12:48
Stringy
Stringy approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think on the basis that this is currently passing CI and that final changes are in #1308 for upstream testing, we can probably merge this

@Molter73 Molter73 merged commit 14167cf into master Sep 4, 2023
@Molter73 Molter73 deleted the mauro/full-multiarch-images branch September 4, 2023 08:37
@Molter73 Molter73 mentioned this pull request Sep 5, 2023
Merged
3 tasks
Molter73 added a commit that referenced this pull request Sep 25, 2023
@Molter73
Fix retag-collector-full workflow
95ebe7b 
This change is missing after the merge of #1271
@Molter73 Molter73 mentioned this pull request Sep 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stringy Stringy Stringy approved these changes

Assignees
No one assigned
Labels
build-full-images skip-integration-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Molter73 @Stringy