Skip to content

ADDED - Dockerfile for cbl-mariner2 kernel-modules #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Smuggla
Copy link

@Smuggla Smuggla commented Jul 21, 2023

Testing Performed

Created Probes uses in stackrox deployments on "Azure Linux" Mariner
They are built upon new kernel deployed by Azure daily.
These can be indexed/downloaded at https://marinerprobes.azureedge.net/

@Smuggla Smuggla requested a review from a team as a code owner July 21, 2023 19:30
@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2023

Hi @Smuggla. Thanks for your PR.

I'm waiting for a stackrox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Smuggla
Copy link
Author

Smuggla commented Jul 21, 2023

Tagging @Maddosaurus

@Molter73
Copy link
Collaborator

Hi @Smuggla! Thanks for your PR!

Adding a new driver builder usually incurs extra effort on our end to make sure the builder and the drivers it builds actually work as intended. Further, with the current changes this dockerfile will not be used by our CI at all. So before we move forward I have a few questions:

  • Have you tried building the CBL-mariner drivers using the existing Fedora builder? Their clang version differ (mariner uses 12 and fedora 14), but they should be close enough.
  • Is the end goal here for us to officially support mariner? If so, please open an issue so we can further discuss the benefits of this change and the additional effort required for it.
  • Finally, the latest version of collector has a BTF enabled probe that should be able to run on supported systems without an extra probe, have you tried running stackrox with it?

@Smuggla Smuggla closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants