Print checksum of drivers being used #1242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing this hash is meant for us to be able to properly identify a driver. This is a byproduct of us building drivers in 2 separate CI systems, since we'll eventually unify the systems, I'd expect this mechanism to be deprecated at some point. However, printing the sha256 to the logs could also prove a useful resource for users if we decide to provide individual checksums for the drivers in the future.
|
Skipping CI for Draft Pull Request. |
|
JoukoVirtanen
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have collector print the sha256 checksum for the driver it uses. Same as #1237, this is part of the groundwork for unifying the upstream and downstream built drivers. By printing the checksum for a driver being used it'll be easier for us to check where the driver comes from in case a user reports an issue.
A small script for downloading drivers from GCP and validating checksums is also provided, in hopes that if we ever need to validate the source of a driver it will make the work somewhat easier.
Checklist
Automated testing
Testing Performed
driver-checksum.shproperly validates files and cleans up after itself.