-
Notifications
You must be signed in to change notification settings - Fork 26
Add the ability to run tests with variable collection methods #1080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
More importantly, this allows to set the collection method to include the new core_bpf driver. This collection method and now be added for PRs using the 'run-corebpf-tests' label.
|
Just realized benchmarking is not being run for the CO-RE bpf probe (or at least it is not showing up in the commit), I'll try to add that as part of this PR as well. |
Benchmarks seem to be running with the CO-RE bpf probe now, but they are not being shown in the report because it is not present in the baseline file (and it won't be until we run benchmarks on the master branch). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think there's probably some more we can do to consolidate the uses of collection method throughout the playbooks (so there's less duplication) but that can be done in a follow up I think.
Description
More importantly, this allows to set the collection method to include the new core_bpf driver. This collection method and now be added for PRs using the 'run-corebpf-tests' label.
Fixes #1067
Checklist
Testing Performed
run-corebpf-tests
runs the tests with thecore_bpf
collection method.run-corebpf-tests
skips the tests with thecore_bpf
collection method.