Skip to content

Add the ability to run tests with variable collection methods #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2023

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Mar 30, 2023

Description

More importantly, this allows to set the collection method to include the new core_bpf driver. This collection method and now be added for PRs using the 'run-corebpf-tests' label.

Fixes #1067

Checklist

  • Investigated and inspected CI test results

Testing Performed

  • Ensure running CI with run-corebpf-tests runs the tests with the core_bpf collection method.
  • Ensure running CI without run-corebpf-tests skips the tests with the core_bpf collection method.

More importantly, this allows to set the collection method to include
the new core_bpf driver. This collection method and now be added for PRs
using the 'run-corebpf-tests' label.
@Molter73 Molter73 added the run-corebpf-tests Use the CO-RE bpf driver in integration tests label Mar 30, 2023
@Molter73 Molter73 requested a review from a team as a code owner March 30, 2023 10:52
@github-actions
Copy link

github-actions bot commented Mar 30, 2023

Kernel Method Without Collector Time (secs) With Collector Time (secs) Baseline median (secs) Collector median (secs) PValue
rhel.rhel-8 ebpf 115.099 120.202 204.92 213.7 🟢
rhel.rhel-8 module 226.382 394.964 187.91 285.98 🟢
ubuntu-os.ubuntu-1804-lts ebpf 249.501 232.929 206.11 213.49 🟢
ubuntu-os.ubuntu-1804-lts module 249.201 425.59 199.27 291.54 🟢
ubuntu-os.ubuntu-2004-lts ebpf 241.169 235.05 236.1 234.97 🟢
ubuntu-os.ubuntu-2004-lts module 245.644 399.095 232.85 321.36 🟢
ubuntu-os.ubuntu-2204-lts ebpf 193.049 191.551 222.56 229.05 🟢
ubuntu-os.ubuntu-2204-lts module 191.311 293.633 213.37 287.88 🟢

@Molter73
Copy link
Collaborator Author

Just realized benchmarking is not being run for the CO-RE bpf probe (or at least it is not showing up in the commit), I'll try to add that as part of this PR as well.

@Molter73
Copy link
Collaborator Author

Benchmarks seem to be running with the CO-RE bpf probe now, but they are not being shown in the report because it is not present in the baseline file (and it won't be until we run benchmarks on the master branch).

@Molter73 Molter73 removed the run-corebpf-tests Use the CO-RE bpf driver in integration tests label Apr 4, 2023
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think there's probably some more we can do to consolidate the uses of collection method throughout the playbooks (so there's less duplication) but that can be done in a follow up I think.

@Molter73 Molter73 merged commit c044207 into master Apr 4, 2023
@Molter73 Molter73 deleted the mauro/enable-corebpf-tests branch April 4, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration testing
2 participants