Skip to content

Conversation

@dmartinol
Copy link
Collaborator

@dmartinol dmartinol commented Nov 4, 2025

Fixes: #42

  • Added missing config options in Config struct
  • Moved sync code from toolhive repo and adapted to not use MCPRegistry for config and status data
    • Adapted tests for the same reason
  • Added status package with initial definition of status data (probably needs to be reviewed)
  • Adapted repo layout to recent changes

@dmartinol dmartinol requested a review from ChrisJBurns November 4, 2025 08:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 76.58643% with 107 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.91%. Comparing base (5533fa2) to head (9a0a985).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sync/manager.go 59.89% 54 Missing and 19 partials ⚠️
pkg/sources/mocks/mock_storage_manager.go 0.00% 12 Missing ⚠️
pkg/sources/mocks/mock_source_handler.go 0.00% 9 Missing ⚠️
pkg/sources/api.go 66.66% 4 Missing and 1 partial ⚠️
pkg/sync/detectors.go 85.71% 2 Missing and 2 partials ⚠️
pkg/filtering/filter_service.go 97.91% 1 Missing and 1 partial ⚠️
pkg/sources/testutils.go 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   64.25%   65.91%   +1.66%     
==========================================
  Files          29       35       +6     
  Lines        1989     2224     +235     
==========================================
+ Hits         1278     1466     +188     
- Misses        611      641      +30     
- Partials      100      117      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

blkt
blkt previously approved these changes Nov 4, 2025
Copy link
Contributor

@blkt blkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please wait for approval from @rdimitrov, @jhrozek, or @ChrisJBurns who should have more context.

ChrisJBurns
ChrisJBurns previously approved these changes Nov 4, 2025
Signed-off-by: Daniele Martinoli <[email protected]>
added few missing configs (more are needed!)

Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
added few missing configs (more are needed!)

Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
rdimitrov
rdimitrov previously approved these changes Nov 5, 2025
Signed-off-by: Daniele Martinoli <[email protected]>
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is the extensive usage of *config.Config, which should probably be an interface, an accessor, or certain config fields instead. But this can be refactored and cleaned up later.

@dmartinol dmartinol merged commit ea16ee7 into stacklok:main Nov 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync Manager

6 participants