-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor sync mgr #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 64.25% 65.91% +1.66%
==========================================
Files 29 35 +6
Lines 1989 2224 +235
==========================================
+ Hits 1278 1466 +188
- Misses 611 641 +30
- Partials 100 117 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but please wait for approval from @rdimitrov, @jhrozek, or @ChrisJBurns who should have more context.
Signed-off-by: Daniele Martinoli <[email protected]>
added few missing configs (more are needed!) Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
added few missing configs (more are needed!) Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
d54ade7 to
b9e0a6f
Compare
Signed-off-by: Daniele Martinoli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is the extensive usage of *config.Config, which should probably be an interface, an accessor, or certain config fields instead. But this can be refactored and cleaned up later.
Fixes: #42