-
Notifications
You must be signed in to change notification settings - Fork 0
Map flavor not found to ResourceExhausted error code #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase onto release-v0.21.0
and drop the commit from the bot, then increment the version file
Signed-off-by: Lukas Jarosch <[email protected]>
7604604
to
d9943b1
Compare
LGTM label has been added. Git tree hash: badfa9c77bd758b8be4d6f071d195eba9b7d3465
|
/test pull-machine-controller-manager-provider-openstack-verify |
/test pull-machine-controller-manager-provider-openstack-integration-tests |
/test pull-machine-controller-manager-provider-openstack-verify |
/override pull-machine-controller-manager-provider-openstack-verify |
@RAPSNX: Overrode contexts on behalf of RAPSNX: pull-machine-controller-manager-provider-openstack-verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override pull-machine-controller-manager-provider-openstack-integration-tests |
@RAPSNX: Overrode contexts on behalf of RAPSNX: pull-machine-controller-manager-provider-openstack-integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RAPSNX The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
Our mcm fork should also not retry if a flavor is not found, hence we simply map this error to ResourceExhausted.
This will then make use of this hack: https://github.com/stackitcloud/machine-controller-manager/pull/6/files
Note: I didn't test this 🤷♂️😆
See: https://jira.schwarz/browse/STACKITSKE-3506