Skip to content

Conversation

lukasjarosch
Copy link

How to categorize this PR?

Our mcm fork should also not retry if a flavor is not found, hence we simply map this error to ResourceExhausted.
This will then make use of this hack: https://github.com/stackitcloud/machine-controller-manager/pull/6/files

Note: I didn't test this 🤷‍♂️😆

See: https://jira.schwarz/browse/STACKITSKE-3506

@lukasjarosch lukasjarosch added the enhancement New feature or request label Aug 5, 2025
@Kumm-Kai Kumm-Kai changed the base branch from master to release-v0.21.0 August 5, 2025 15:30
Copy link
Member

@Kumm-Kai Kumm-Kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase onto release-v0.21.0 and drop the commit from the bot, then increment the version file

@lukasjarosch lukasjarosch force-pushed the flavor-not-found-mapping branch from 7604604 to d9943b1 Compare August 7, 2025 07:30
@ske-prow ske-prow bot added the lgtm label Aug 11, 2025
@ske-prow
Copy link

ske-prow bot commented Aug 11, 2025

LGTM label has been added.

Git tree hash: badfa9c77bd758b8be4d6f071d195eba9b7d3465

@RAPSNX
Copy link

RAPSNX commented Aug 22, 2025

/test pull-machine-controller-manager-provider-openstack-verify

@RAPSNX
Copy link

RAPSNX commented Aug 22, 2025

/test pull-machine-controller-manager-provider-openstack-integration-tests

@RAPSNX RAPSNX requested a review from Kumm-Kai August 22, 2025 12:12
@RAPSNX
Copy link

RAPSNX commented Aug 22, 2025

/test pull-machine-controller-manager-provider-openstack-verify

@RAPSNX
Copy link

RAPSNX commented Aug 22, 2025

/override pull-machine-controller-manager-provider-openstack-verify

@ske-prow
Copy link

ske-prow bot commented Aug 22, 2025

@RAPSNX: Overrode contexts on behalf of RAPSNX: pull-machine-controller-manager-provider-openstack-verify

In response to this:

/override pull-machine-controller-manager-provider-openstack-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RAPSNX
Copy link

RAPSNX commented Aug 22, 2025

/override pull-machine-controller-manager-provider-openstack-integration-tests

@ske-prow
Copy link

ske-prow bot commented Aug 22, 2025

@RAPSNX: Overrode contexts on behalf of RAPSNX: pull-machine-controller-manager-provider-openstack-integration-tests

In response to this:

/override pull-machine-controller-manager-provider-openstack-integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ske-prow
Copy link

ske-prow bot commented Aug 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RAPSNX

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RAPSNX RAPSNX merged commit badf72f into release-v0.21.0 Aug 22, 2025
3 of 4 checks passed
@RAPSNX RAPSNX deleted the flavor-not-found-mapping branch August 22, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants