-
Notifications
You must be signed in to change notification settings - Fork 2
feat(native): Add toBeVisible #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JoseLion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! I left a few suggestion, let me know if you have any question 🙂
35e5052 to
82fa78b
Compare
lopenchi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
4cfe69c to
dcded59
Compare
JoseLion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I left a couple of comments to help make the code easier to understand. Let me know what you think!
Co-authored-by: Jose Luis Leon <[email protected]>
JoseLion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left one minor nitpick, but this should be ready to merge! 🎉
Co-authored-by: Jose Luis Leon <[email protected]>
Co-authored-by: Carolina López <[email protected]> Co-authored-by: Jose Luis Leon <[email protected]> Co-authored-by: Carolina Lopez <[email protected]>
This PR adds the
toBeVisiblematcher for React Native