Skip to content

Conversation

@kdquistanchala
Copy link
Contributor

This PR adds the toBeVisible matcher for React Native

@kdquistanchala kdquistanchala changed the base branch from main to feat/native-to-be-empty March 21, 2025 22:13
@kdquistanchala kdquistanchala self-assigned this Mar 24, 2025
@kdquistanchala kdquistanchala added the enhancement New feature or request label Mar 24, 2025
@kdquistanchala kdquistanchala requested a review from suany0805 April 3, 2025 21:15
Copy link
Contributor

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! I left a few suggestion, let me know if you have any question 🙂

Base automatically changed from feat/native-to-be-empty to main April 25, 2025 17:51
@kdquistanchala kdquistanchala force-pushed the feat/native-to-be-visible branch from 35e5052 to 82fa78b Compare April 25, 2025 18:41
@kdquistanchala kdquistanchala requested a review from JoseLion April 25, 2025 20:54
Copy link
Contributor

@lopenchi lopenchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lopenchi lopenchi force-pushed the feat/native-to-be-visible branch from 4cfe69c to dcded59 Compare July 14, 2025 21:42
Copy link
Contributor

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I left a couple of comments to help make the code easier to understand. Let me know what you think!

Copy link
Contributor

@JoseLion JoseLion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left one minor nitpick, but this should be ready to merge! 🎉

Co-authored-by: Jose Luis Leon <[email protected]>
@lopenchi lopenchi merged commit e672c04 into main Jul 22, 2025
4 checks passed
@lopenchi lopenchi deleted the feat/native-to-be-visible branch July 22, 2025 21:38
SbsCruz pushed a commit that referenced this pull request Dec 26, 2025
Co-authored-by: Carolina López <[email protected]>
Co-authored-by: Jose Luis Leon <[email protected]>
Co-authored-by: Carolina Lopez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants